Reduce past note opening delay - #7072
Merged
Merged
Conversation
Preload selected session content before mounting the editor.
✅ Deploy Preview for anarlog canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc5e7ad. Configure here.
| openCurrent({ id: sessionId, type: "sessions" }); | ||
| setIsOpening(false); | ||
| } | ||
| }, [openCurrent, sessionId]); |
There was a problem hiding this comment.
Stale open wins navigation race
Medium Severity
openSession always calls openCurrent in finally after preloadSession finishes, with no check that this click is still the latest one. A slower preload from an earlier row can finish after a newer click and switch the tab back to the wrong note.
Reviewed by Cursor Bugbot for commit dc5e7ad. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preload selected session content before mounting the editor.
Note
Medium Risk
Changes when notes switch and can briefly serve cached session body before the live query. Navigation still proceeds if preload fails.
Overview
Reduces delay when opening past notes from the sidebar by prefetching session content before the editor mounts.
preloadSessionruns the same SQLite session query asuseSession, caches one result for 5s, and dedupes in-flight loads. While the live subscription is still starting,useSessionreturns that prefetched record.Timeline session rows start preload on pointer-down/focus and wait for it before switching tabs, showing a spinner on the current row until then. Locked notes skip the hover preload.
Reviewed by Cursor Bugbot for commit dc5e7ad. Bugbot is set up for automated code reviews on this repo. Configure here.